Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Synchronize with BCD v5.7.4 #38709

Merged
merged 2 commits into from
Mar 21, 2025
Merged

Synchronize with BCD v5.7.4 #38709

merged 2 commits into from
Mar 21, 2025

Conversation

OnkarRuikar
Copy link
Contributor

@OnkarRuikar OnkarRuikar requested review from a team as code owners March 19, 2025 01:10
@OnkarRuikar OnkarRuikar requested review from hamishwillee and wbamberg and removed request for a team March 19, 2025 01:10
@github-actions github-actions bot added Content:WebAPI Web API docs Content:HTTP HTTP docs size/s [PR only] 6-50 LoC changed labels Mar 19, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 19, 2025 •
edited
Loading

Preview URLs

Flaws (1)

Note! 4 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Web/HTTP/Reference/Headers/Content-Security-Policy
Title: Content-Security-Policy (CSP)
Flaw count: 1

  • unknown:
    • No generic content config found

(comment last updated: 2025-03-21 03:41:14)

bsmth
bsmth approved these changes Mar 19, 2025
View reviewed changes
Copy link
Member

@bsmth bsmth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions to apply for inline statuses, but otherwise good to go.

For future us, it would be great to have "reason for change" somewhere, because it's not based on recently-changing support (X is now supported in Y browser in this bug), one is no longer categorized as experimental because of:

https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines/index.md#setting-experimental

The feature has been supported by default and without major changes by some browser for two or more years.

And the other has a spec link added standard_track value changed. We have a link to release notes for BCD, but they don't list these kinds of changes (yet?).

hamishwillee
hamishwillee approved these changes Mar 21, 2025
View reviewed changes
Copy link
Collaborator

@hamishwillee hamishwillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Agree with @bsmth that a reason would be handy for some these changes (also that we should look at inline macro updates too)

@OnkarRuikar
Copy link
Contributor Author

also that we should look at inline macro updates too

I don't know if we have a guideline for this, but using inline status macros in text is not a good idea. It's haaard to maintain. The bot can't reliably figure out which API/feature the member belongs to. For example, in the 'enabled' {{experimental_inline}} property is used for bla bla.. it is impossible to figure out if it is ABC.enabled or XYZ.enabled.
There are only <10 occurrences left and rest of the inline status macros have been used only in the lists(definition or normal ones).

@OnkarRuikar OnkarRuikar requested a review from bsmth March 21, 2025 04:01
@bsmth
Copy link
Member

bsmth commented Mar 21, 2025

Thanks, Onkar!

@bsmth bsmth merged commit 28da811 into mdn:main Mar 21, 2025
8 checks passed
@OnkarRuikar OnkarRuikar deleted the sync_bcd branch March 22, 2025 01:08
bramus pushed a commit to bramus/mdn-content that referenced this pull request Apr 1, 2025
@OnkarRuikar @bsmth @bramus
Synchronize with BCD v5.7.4 (mdn#38709)
b78c2b4 
* Synchronize with BCD v5.7.4

* Apply suggestions from code review

Co-authored-by: Brian Smith <[email protected]>

---------

Co-authored-by: OnkarRuikar <[email protected]>
Co-authored-by: Brian Smith <[email protected]>
wbamberg added a commit to wbamberg/content that referenced this pull request Apr 4, 2025
@wbamberg
Merge remote-tracking branch 'upstream/main' into cross-site-leaks
540aff6 
* upstream/main: (172 commits)
  chore: improve code style guide (mdn#38715)
  fix: typo on `Error.isError()` page (mdn#38754)
  plural consistency (mdn#38747)
  fix: auto-cleanup by bot (mdn#38695)
  Synchronize with BCD v5.7.4 (mdn#38709)
  Add docs for JS self-profiling API (mdn#37796)
  Better SameSite docs (mdn#38710)
  Added missing explanation for Array Literals (mdn#38745)
  Add a page on CSRF (mdn#38151)
  Fix description of several Range methods (mdn#38518)
  Remove extraneous span (mdn#38696)
  Add a definition for media containers, improve how the media files are defined and Remove wrong information (mdn#38721)
  Move visited selector guide to CSS selectors module (mdn#38642)
  Make JSON learning article more technically precise (mdn#38644)
  Make translate3d() interactive example code valid (mdn#38647)
  Clarity on Safari support for custom elements (mdn#38727)
  feat(css): Link to learning doc about text direction (mdn#38719)
  Fix typo (mdn#38739)
  move guide to module: inline formatting context (mdn#38637)
  Fix CSS pseudo-class lists (mdn#38576)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hamishwillee hamishwillee hamishwillee approved these changes

@wbamberg wbamberg Awaiting requested review from wbamberg wbamberg is a code owner automatically assigned from mdn/yari-content-web-api

@bsmth bsmth Awaiting requested review from bsmth

Assignees
No one assigned
Labels
Content:HTTP HTTP docs Content:WebAPI Web API docs size/s [PR only] 6-50 LoC changed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OnkarRuikar @bsmth @hamishwillee